Pro_News version 3.2: Lots of Improvement

Forum dedicated to discussion of articles posted in Home page of Pro_News
Reply to topicReply to topic
Go to page  Previous  1, 2, 3, 4, 5, 6, 7, 8, 9, 10  Next 

  
4 Aug '09 Tue Aug 04, 2009 10:05    
layingback
Site Admin  
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Agree on the %Y%m%d change. I don't know why it doesn't work correctly on your system (Windows PHP perhaps?), but agree that the change makes more sense.) Thanks! But be aware that it occurs in many places in the code.

On the different style of form for Calendar date and Article display date, I understand your concern. While I agree with you, the Event date needs to stays as it is. (The Hour being blank signifies a Whole Day event, vs. a normal by-the-hour event.) So the one to change would be the Article date - but this time stuff is so hard to test that I'm loathe to touch it. (Needs to be tested with server in same time zone, earlier time zone, later time zone and GMT - a lot of testing.)

BTW, it all stems from eliminating the (additional) Yes/No option which News uses to say if you want scheduling or not. Adding the Yes/No makes code logic *MUCH* simpler, but it is a poor user interface design - too easy to set the date/time, forget to set Yes/No and proceed thinking you have a timed event set up when you don't. Similarly I didn't want a Whole Day Yes/No button for Events. So this I will leave for another day - if not forever! Wink



layingback's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

2.6.32 / 1.3 - 2.4 / 5.5 - 5.6 / 5.4 - 5.5 / 9.4

 
 
 
 
  
4 Aug '09 Tue Aug 04, 2009 10:27    
masino_sinaga
Developer  Developer
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Thanks for the warning about replacing it. I have replaced it in the other places. Yes, I am running PHP in Windows XP as my testing-environment.
Actually, %Y also still works on Linux, and thanks for your comment/advice about this.

I also agree with you to make the Hour and Minute become a blank value as this event is more suitable as the whole day event. But, for this, I think it's better to add additional info for user, for example: "Leave blank in Hour and Minute to make the event as the whole day event", etc. So, the default value for Hour and Minute will still have the same value with the schedule date (the time when this form was opened/accessed). And when we set "No" for the schedule feature, the value for Event Start and End still have the value with the date and time when the form was opened.

Thank you.

Sincerely,
Masino Sinaga


_________________

www.visualbasicindonesia.com



masino_sinaga's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

Linux / 2.2.11 (Unix) / 5.0.77-community- log / 5.2.9 / 9.2.1

 
 
 
 
  
4 Aug '09 Tue Aug 04, 2009 10:32    
layingback
Site Admin  
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Well I think I have the Post by Visitor code in place now. Removing the is_user() test as recommended by fishingfan was easy Wink But it also meant a big change to the seccat routine (which displays Sections/Categories to select), so that the visitor only saw Sections/Categories where he/she could post.

Plus dealing with the case when that became a null set. Also fleshed out support for Anonymous Only setting - I now stop registered users posting to those. Evil or Very Mad

Plus I found and fixed a Submit Article form template display issue if there wasn't a matching template in submit/.

Phew! Who's crazy idea was it to add Post by Section? Laughing

The above will require thorough testing of user side submit, please.

Hope to build and release soon, not sure if I have enough time today - depends how smoothly the CVS work goes...



layingback's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

2.6.32 / 1.3 - 2.4 / 5.5 - 5.6 / 5.4 - 5.5 / 9.4

 
 
 
 
  
4 Aug '09 Tue Aug 04, 2009 13:12    
layingback
Site Admin  
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

OK, 3.2.0.3RC2 is up. Hopefully this one will work flawlessly! Rolling Eyes



layingback's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

2.6.32 / 1.3 - 2.4 / 5.5 - 5.6 / 5.4 - 5.5 / 9.4

 
 
 
 
  
4 Aug '09 Tue Aug 04, 2009 13:33    
masino_sinaga
Developer  Developer
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Thanks for the quick result! Wonderful job.
I have just downloaded. Again, I was the first who downloaded it. Wink
I will let you know the result asap. Thanks.

Sincerely,
Masino Sinaga


_________________

www.visualbasicindonesia.com



masino_sinaga's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

Linux / 2.2.11 (Unix) / 5.0.77-community- log / 5.2.9 / 9.2.1

 
 
 
 
  
4 Aug '09 Tue Aug 04, 2009 15:31    
masino_sinaga
Developer  Developer
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Hi Layingback,

Good job. Everything works good now.

Except for this, I think: Wink

Don't worry, just a little bit of change. I think you need to apply this before you release the stable version. This is only for the Pro_News Menu block.

I got this (see the three screenshots below) when I ran via Internet Explorer (IE) browser. Mozilla Firefox is okay. Only in IE the look is not too good.


Then, I changed your code in pro_news.css file:

From this:

Code:
#pn_menutree, #pn_menutree ul {
  list-style: none outside;
  margin-left: -32px;
}
#pn_menutree li.pn_hide ul {
 display: none;
}
#pn_menutree li.pn_show ul {
 display: block;
}
#pn_menutree li.pn_cat {
  padding-left: 16px;
  background: url('../images/pro_news/page.png') no-repeat center left;
}
#pn_menutree li.pn_hide .clk {
  cursor: pointer;
  padding-left: 16px;
  background: url('../images/pro_news/plus.png') no-repeat center left;
}
#pn_menutree li.pn_show .clk {
  cursor: pointer;
  padding-left: 16px;
  background: url('../images/pro_news/minus.png') no-repeat center left;
}



Become this:

Code:
#pn_menutree, #pn_menutree ul {
  list-style: none outside;
  padding-left: 4px;
}
#pn_menutree li.pn_hide ul {
 display: none;
}
#pn_menutree li.pn_show ul {
 display: block;
 padding-left: 4px;
}
#pn_menutree li.pn_cat {
  padding-left: 16px;
  background: url('../images/pro_news/page.png') no-repeat center left;
}
#pn_menutree li.pn_hide .clk {
  cursor: pointer;
  padding-left: 18px;
  background: url('../images/pro_news/plus.png') no-repeat center left;
}
#pn_menutree li.pn_show .clk {
  cursor: pointer;
  padding-left: 12px;
  background: url('../images/pro_news/minus.png') no-repeat center left;
}



Besides that, I also change the code in your block-ProNews_Menu.php in order that the block will import the pro_news.css to the block. If this css import does not exist, then the page icon will change become the bullet icon.

From this:

PHP:
if (!defined('CPG_NUKE')) { exit; }

global
$Blocks;

if (
is_active('Pro_News')) {
require_once('modules/Pro_News/functions.php');
$bid = (isset($block['bid'])) ? $block['bid'] : intval($bid);
$content = ProNews::get_block_menu($bid);
}
if (!
$content) {$content = 'ERROR';
return trigger_error('Menu Block '.$block['bid'].' ('.$block['title'].') returned no content', E_USER_NOTICE);
} else {
$content .= "\n".'<script language="JavaScript" type="text/javascript">

<!--
function pn_toggle(x)
{ x.className = (x.className=="pn_show") ? "pn_hide" : "pn_show"; }
//-->
</script>'
;

}
?>




Become this:

PHP:
if (!defined('CPG_NUKE')) { exit; }

global
$Blocks, $CPG_SESS; // modified by Masino Sinaga, June 30, 2009

if (is_active('Pro_News')) {
require_once('modules/Pro_News/functions.php');

$pnstyle = '<style type="text/css">
<!--
@import url(themes/'
.$CPG_SESS['theme'].'/style/pro_news.css);/--> </style>'; // added by Masino Sinaga, June 30, 2009 for support CSS

$bid = (isset($block['bid'])) ? $block['bid'] : intval($bid);
$content = ProNews::get_block_menu($bid);
}
if (!
$content) {$content = 'ERROR';
return trigger_error('Menu Block '.$block['bid'].' ('.$block['title'].') returned no content', E_USER_NOTICE);
} else {
// modified by Masino Sinaga, June 30, 2009 in order to support CSS for Pro_News menu block (if set)
$content .= $pnstyle."\n".'<script language="JavaScript" type="text/javascript">

<!--
function pn_toggle(x)
{ x.className = (x.className=="pn_show") ? "pn_hide" : "pn_show"; }
//-->
</script>'
;

}
?>



And everything is looking good now. Smile

Thanks for your hard work until now, layingback. Keep up the good work!

Sincerely,
Masino Sinaga


_________________

www.visualbasicindonesia.com



masino_sinaga's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

Linux / 2.2.11 (Unix) / 5.0.77-community- log / 5.2.9 / 9.2.1

 
 
 
 
  
5 Aug '09 Wed Aug 05, 2009 08:30    
layingback
Site Admin  
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Thanks for the feedback. Hopefully fishingfan will report similar good news Wink

The missing css call was because I had assumed that no-one would want the Pro_News menu up if Pro-News wasn't the module running. I.e. I expected the menu block to be marked to run only with Pro_News.

It can be added, but will create another XHTML error flag I suspect! (Unless can add a $modulename == 'Pro_News' conditional to your style load ... )

But the IE issue: What version of IE are you running? And do you know why pro_newsie.css isn't being used? (Not a new IE8 inconsistency I hope! Evil or Very Mad ) Because pro_newsie.css has margin already set to 8 (vs. 16). Which seemed to work ok on IE 5.5, 6 & 7 (only versions that I have).

Final question: your first image above - the "ok" one - still shows a bullet, to the very left of the block, slightly outside of the border. So something is still not quite right yet ...



layingback's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

2.6.32 / 1.3 - 2.4 / 5.5 - 5.6 / 5.4 - 5.5 / 9.4

 
 
 
 
  
5 Aug '09 Wed Aug 05, 2009 09:31    
masino_sinaga
Developer  Developer
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

I am running IE8.

Yes. I think it's because while I modified the .css file, I captured the screen, meanwhile I should have to edit also some code in that .css file.

Actually, the final result in mine, that bullet has gone. Wink

Sincerely,
Masino Sinaga


_________________

www.visualbasicindonesia.com



masino_sinaga's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

Linux / 2.2.11 (Unix) / 5.0.77-community- log / 5.2.9 / 9.2.1

 
 
 
 
  
5 Aug '09 Wed Aug 05, 2009 09:40    
layingback
Site Admin  
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Ok, so bullet no longer an issue. But is IE8 really ignoring pro_newsie.css? Can you make some temporary wild change in pro_newsie.css and see if IE8 sees it? IE6 & 7 should. Because if it does see it, I'd like to put the change in there, so we don't have to (re-)test Safari, Opera, Konqueror, etc., to make sure we haven't broken it in those.

TIA



layingback's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

2.6.32 / 1.3 - 2.4 / 5.5 - 5.6 / 5.4 - 5.5 / 9.4

 
 
 
 
  
5 Aug '09 Wed Aug 05, 2009 09:49    
masino_sinaga
Developer  Developer
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Sure, I will try to make it. But please try also in yours, perhaps I have missed something. Wink

Hm, I think I have some trouble in mine, especially while displaying another module in home page. I will try to find out what's the problem here. Sad

Thanks.

Sincerely,
Masino Sinaga


_________________

www.visualbasicindonesia.com



masino_sinaga's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

Linux / 2.2.11 (Unix) / 5.0.77-community- log / 5.2.9 / 9.2.1

 
 
 
 
  
5 Aug '09 Wed Aug 05, 2009 14:22    
layingback
Site Admin  
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

@ Masino: OK, can you try this please (as I don't have IE8)?

Replace your block-ProNews_menu.php code with this that I believe is the correct code:

PHP:



Hopefully the above change will work without any changes to the actual css files. I.e. as the pro_news.css file was before you made your margin changes.

Please test when Pro_News is NOT the current module.

If the menu block displays the icons correctly, but the margins are still incorrect, and the corrections in pro_newsie.css look as if they will fix things, then you will probably just need to mess with the ereg('MSIE 7.0', $user_agent) conditional to include IE8. If you left me know what the ereg() statement is, I will then also include in Pro_News/index.php, line 24, so it's correct when Pro_News is the current module.

TIA!



layingback's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

2.6.32 / 1.3 - 2.4 / 5.5 - 5.6 / 5.4 - 5.5 / 9.4

 
 
 
 
  
5 Aug '09 Wed Aug 05, 2009 16:01    
fishingfan
Developer  Developer
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Well I can report that this is working well.

I have one bug that is in the other RC2 version as well. I've seen it when using the submit form.

The bug is in functions.php -> function dttime_edit

The error is reported if you turn php error reporting on in that the Pn_date function is receiving a string when expecting a long.

I resolved this ( it was stopping my submit form from showing ) by adding in this line in the dttime_edit function.

PHP:
        $gmttime = intval($gmttime);  



I really would like to see pagination added to the headlines if this is possible (maybe another release). If there's a way of displaying headlines like display with pagination then I can't see it. Smile



fishingfan's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

Linux,Apache2.2,mysql5,php5,dragonfly 9.2

 
 
 
 
  
5 Aug '09 Wed Aug 05, 2009 16:56    
layingback
Site Admin  
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

A Warning shouldn't affect anything - usually means the PHP interpreter has made the right assumption. But it's always good to knock them out! Smile

Thanks!

Do you have a link to a site where you need pagination on Headlines? So I can grasp the concept/context ...



layingback's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

2.6.32 / 1.3 - 2.4 / 5.5 - 5.6 / 5.4 - 5.5 / 9.4

 
 
 
 
  
6 Aug '09 Thu Aug 06, 2009 04:35    
masino_sinaga
Developer  Developer
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

- layingback

@ Masino: OK, can you try this please (as I don't have IE8)?

Replace your block-ProNews_menu.php code with this that I believe is the correct code


Hi Layingback,

Thanks for the code. I have tried it using IE8. I attached the screenshot (see below).

Hope this is helpful.

Sincerely,
Masino Sinaga


_________________

www.visualbasicindonesia.com



masino_sinaga's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

Linux / 2.2.11 (Unix) / 5.0.77-community- log / 5.2.9 / 9.2.1

 
 
 
 
  
6 Aug '09 Thu Aug 06, 2009 11:09    
fishingfan
Developer  Developer
  •  

Post Re: Pro_News version 3.2: Lots of Improvement

Yes you can see it on www.Fishing-Fan.co.uk (Kinda of explains my username Laughing ).

I've just started to use Pro-News here instead of the news module, having moved at the start of the year to Dragonfly from PostNuke.

I'm currently starting with 2 sections, the one I'd like to see the Pagination on is my Fishing News section, which has over 200 articles. You can see it on the front page.



fishingfan's server specs (Server OS / Apache / MySQL / PHP / DragonflyCMS)

Linux,Apache2.2,mysql5,php5,dragonfly 9.2

 
 
 
 
Link  QR 
Share this Printer Friendly Page  facebook   google+   linkedin   twitthis  
Show more ...
Go to page  Previous  1, 2, 3, 4, 5, 6, 7, 8, 9, 10  Next


Go to page  Previous  1, 2, 3, 4, 5, 6, 7, 8, 9, 10  Next